Skip to content

Commit

Permalink
Merge pull request #421 from stripe/ob-update-ca-bundle
Browse files Browse the repository at this point in the history
Update CA bundle and add script for future updates
  • Loading branch information
brandur-stripe authored Jan 17, 2018
2 parents 0b5d382 + 88e8065 commit 58fadb2
Show file tree
Hide file tree
Showing 3 changed files with 448 additions and 697 deletions.
11 changes: 8 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ require_once('/path/to/stripe-php/init.php');

## Dependencies

The bindings require the following extension in order to work properly:
The bindings require the following extensions in order to work properly:

- [`curl`](https://secure.php.net/manual/en/book.curl.php), although you can use your own non-cURL client if you prefer
- [`json`](https://secure.php.net/manual/en/book.json.php)
Expand Down Expand Up @@ -148,8 +148,6 @@ Install dependencies:
composer install
```

## Tests

The test suite depends on [stripe-mock], so make sure to fetch and run it from a
background terminal ([stripe-mock's README][stripe-mock] also contains
instructions for installing via Homebrew and other methods):
Expand All @@ -169,6 +167,12 @@ Or to run an individual test file:
./vendor/bin/phpunit tests/UtilTest.php
```

Update bundled CA certificates from the [Mozilla cURL release][curl]:

```bash
./update_certs.php
```

## Attention plugin developers

Are you writing a plugin that integrates Stripe and embeds our library? Then please use the `setAppInfo` function to identify your plugin. For example:
Expand All @@ -183,5 +187,6 @@ The method should be called once, before any request is sent to the API. The sec

See the "SSL / TLS compatibility issues" paragraph above for full context. If you want to ensure that your plugin can be used on all systems, you should add a configuration option to let your users choose between different values for `CURLOPT_SSLVERSION`: none (default), `CURL_SSLVERSION_TLSv1` and `CURL_SSLVERSION_TLSv1_2`.

[curl]: http://curl.haxx.se/docs/caextract.html
[psr3]: http://www.php-fig.org/psr/psr-3/
[stripe-mock]: https://github.com/stripe/stripe-mock
Loading

0 comments on commit 58fadb2

Please sign in to comment.