fix: Update RequestOptions#redactedApiKey to stop exploding null. (#1289

)
stripe · May 23, 2022 · 3a95278 · 3a95278
1 parent 47cfc40
commit 3a95278
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/Util/RequestOptions.php b/lib/Util/RequestOptions.php
@@ -154,8 +154,13 @@ public static function parse($options, $strict = false)
         throw new \Stripe\Exception\InvalidArgumentException($message);
     }
 
+    /** @return string */
     private function redactedApiKey()
     {
+        if (null === $this->apiKey) {
+            return '';
+        }
+
         $pieces = \explode('_', $this->apiKey, 3);
         $last = \array_pop($pieces);
         $redactedLast = \strlen($last) > 4

diff --git a/tests/Stripe/Util/RequestOptionsTest.php b/tests/Stripe/Util/RequestOptionsTest.php
@@ -168,5 +168,9 @@ public function testDebugInfo()
         $opts = RequestOptions::parse(['api_key' => '1234567890abcdefghijklmn']);
         $debugInfo = \print_r($opts, true);
         static::compatAssertStringContainsString('[apiKey] => ********************klmn', $debugInfo);
+
+        $opts = RequestOptions::parse([]);
+        $debugInfo = \print_r($opts, true);
+        static::compatAssertStringContainsString("[apiKey] => \n", $debugInfo);
     }
 }