Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FileUploads to Files #500

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Rename FileUploads to Files #500

merged 1 commit into from
Sep 24, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

  • Rename stripe.fileUploads to stripe.files (but keep stripe.fileUploads as an alias for BC)
  • Have the retrieve and list requests hit api.stripe.com instead of uploads.stripe.com
  • Have the create request hit files.stripe.com instead of uploads.stripe.com (this is actually the same host, but files.stripe.com is the new canonical name)

@brandur-stripe
Copy link
Contributor

LGTM!

@ob-stripe ob-stripe merged commit dada2ed into master Sep 24, 2018
@ob-stripe ob-stripe deleted the ob-file-resource branch September 24, 2018 13:28
@ob-stripe
Copy link
Contributor Author

Released as 6.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brandur-stripe brandur-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @brandur-stripe