Don't mutate error.type during minification #2043
Merged
+133
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anniel-stripe
requested review from
a team and
richardm-stripe
and removed request for
a team
pakrym-stripe
approved these changes
Mar 21, 2024
This was referenced Jun 2, 2024
This was referenced Aug 2, 2024
This was referenced Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
typeproperty on error objects was set tothis.constructor.name, which gets mutated during minification. To fix this, explicitly set thetypeto a hardcoded string for known subclasses ofStripeError. This also keeps the default behavior the same in theStripeErrorparent class for backwards compatibility.I've added a test project to verify
error.typedoes not get minified when bundling / minifying with esbuild.Fixes #2042