Move all platform-specific implementations into PlatformFunctions #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anniel-stripe
force-pushed
the
anniel-platform-functions-refactor
branch
from
a52996c to
ef4162c
Compare
pakrym-stripe
approved these changes
Feb 7, 2023
…ssertion, more specific return type on createStripe
anniel-stripe
force-pushed
the
anniel-platform-functions-refactor
branch
from
81c80d5 to
45d9d1d
Compare
…tpClient if httpAgent config option is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
createStripeandcreateWebhooksfunction that takes in platform functions as a parameter, removing the need for a global_platformFunctionsfield.create...CryptoProviderandcreate...HttpClientintoPlatformFunctions).a. l removed
createHttpClientfrom Stripe and_createCryptoProviderfromWebhook, since we can't have a "default" implementation ascreate...CryptoProviderandcreate...HttpClienttake different types of arguments. The user will have to keep specifyinghttpClienton the stripe config andcryptoProviderinconstructEvent/constructEventAsync.Testing
Added tests in
PlatformFunctions.spec.tsand removed no-op tests fromstripe.spec.ts. Also ran manual end-to-end tests in a Cloudflare Pages Functions and Cloudflare Worker project.