Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #1242

Merged
merged 2 commits into from
Sep 15, 2021
Merged

API Updates #1242

merged 2 commits into from
Sep 15, 2021

Conversation

richardm-stripe
Copy link
Contributor

Codegen for openapi 95a1ab8.
r? @dcr-stripe
cc @stripe/api-libraries

Changelog

  • Change BillingPortal.Configuration.features.subscription_cancel.cancellation_reason to be required
  • Add support for default_for on CheckoutSessionCreateParams.payment_method_options.acss_debit.mandate_options, Checkout.Session.payment_method_options.acss_debit.mandate_options, Mandate.payment_method_details.acss_debit, SetupIntentCreateParams.payment_method_options.acss_debit.mandate_options, SetupIntentUpdateParams.payment_method_options.acss_debit.mandate_options, SetupIntentConfirmParams.payment_method_options.acss_debit.mandate_options, and SetupIntent.payment_method_options.acss_debit.mandate_options
  • Add support for acss_debit on InvoiceCreateParams.payment_settings.payment_method_options, InvoiceUpdateParams.payment_settings.payment_method_options, Invoice.payment_settings.payment_method_options, SubscriptionCreateParams.payment_settings.payment_method_options, SubscriptionUpdateParams.payment_settings.payment_method_options, and Subscription.payment_settings.payment_method_options
  • Add support for new value acss_debit on enums InvoiceCreateParams.payment_settings.payment_method_types[], InvoiceUpdateParams.payment_settings.payment_method_types[], Invoice.payment_settings.payment_method_types[], SubscriptionCreateParams.payment_settings.payment_method_types[], SubscriptionUpdateParams.payment_settings.payment_method_types[], and Subscription.payment_settings.payment_method_types[]
  • Add support for livemode on Reporting.ReportType

@dcr-stripe
Copy link
Contributor

Whoops, build is failing because of me:

Error: types/Webhooks.d.ts(43,26): error TS2304: Cannot find name 'CryptoProvider'.

Sending you a codegen PR.

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you've merged in the suggestion.

@@ -1,7 +1,6 @@
// File generated from our OpenAPI spec

///<reference path='../lib.d.ts' />
///<reference path='../crypto/crypto.d.ts' />
///<reference path='../net/net.d.ts' />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
///<reference path='../net/net.d.ts' />
///<reference path='../crypto/crypto.d.ts' />
///<reference path='../net/net.d.ts' />

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardm-stripe richardm-stripe merged commit db9e062 into master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants