Remove includeBasic.

stripe · Jul 26, 2021 · 245c0e1 · 245c0e1
1 parent d3a1687
commit 245c0e1
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 64 deletions.
diff --git a/lib/StripeMethod.basic.js b/lib/StripeMethod.basic.js
diff --git a/lib/StripeResource.js b/lib/StripeResource.js
@@ -22,7 +22,6 @@ StripeResource.extend = utils.protoExtend;
 
 // Expose method-creator & prepared (basic) methods
 StripeResource.method = require('./StripeMethod');
-StripeResource.BASIC_METHODS = require('./StripeMethod.basic');
 
 StripeResource.MAX_BUFFERED_REQUEST_METRICS = 100;
 const MAX_RETRY_AFTER_WAIT = 60;
@@ -44,12 +43,6 @@ function StripeResource(stripe, deprecatedUrlData) {
   this.resourcePath = this.path;
   this.path = utils.makeURLInterpolator(this.path);
 
-  if (this.includeBasic) {
-    this.includeBasic.forEach(function(methodName) {
-      this[methodName] = StripeResource.BASIC_METHODS[methodName];
-    }, this);
-  }
-
   this.initialize(...arguments);
 }
 

diff --git a/types/lib.d.ts b/types/lib.d.ts
@@ -8,38 +8,13 @@ declare module 'stripe' {
     export class StripeResource {
       static extend<
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        T extends {[prop: string]: any} & {
-          includeBasic?: Array<
-            'create' | 'retrieve' | 'update' | 'list' | 'del'
-          >;
-        }
+        T extends {[prop: string]: any}
       >(spec: T): StripeResource & T;
       static method(spec: {
         method: string;
         path: string;
         methodType?: 'list';
       }): (...args: any[]) => object; //eslint-disable-line @typescript-eslint/no-explicit-any
-      static BASIC_METHODS: {
-        create<T>(
-          params: CouponCreateParams,
-          options?: RequestOptions
-        ): Promise<T>;
-        retrieve<T>(
-          id: string,
-          params?: CouponRetrieveParams,
-          options?: RequestOptions
-        ): Promise<T>;
-        update<T>(
-          id: string,
-          params?: CouponUpdateParams,
-          options?: RequestOptions
-        ): Promise<T>;
-        list<T>(
-          params?: CouponListParams,
-          options?: RequestOptions
-        ): ApiListPromise<T>;
-        del<T>(id: string, options?: RequestOptions): Promise<T>;
-      };
       static MAX_BUFFERED_REQUEST_METRICS: number;
     }
     export type LatestApiVersion = '2020-08-27';

diff --git a/types/test/typescriptTest.ts b/types/test/typescriptTest.ts
@@ -175,7 +175,6 @@ const stripeCardError: Stripe.StripeCardError = Stripe.errors.generate({
 });
 
 Stripe.StripeResource.extend({
-  includeBasic: ['retrieve'],
   foo: Stripe.StripeResource.method({
     method: 'create',
     path: 'foo',