-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge changes to move server into its own package #265
Conversation
Now the server can be embedded inside of a Go project and integrated with go test.
Properly formats the header of the file so that it passes golint.
Because the Vendor directory has been removed and golint works fine.
False positive in golint is catching auto-generated file comment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good! The only thing is that I think we should remove bindata.go
as the path has moved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarified IRL! I understand the bindata commands now! Good to merge!
Co-authored-by: Richard Marmorstein <[email protected]>
Co-authored-by: Richard Marmorstein <[email protected]>
Notify
r? @richardm-stripe
cc @dcr-stripe @stripe/api-libraries
Summary
Based on the changes from #238 (thank you @Splizard) with conflicts resolved against the master branch.
The original intent was to fix issue #206 and allow running embedded version of the server.
Detailed changes:
verbose
variable and include it into server, so it does not become part of the API (not sure what to do withVersion
though, usually it is OK to leave it as it is set by ldflags).Finally, it looks like it's a lot of changes, but mostly it's shuffling code around to a different package.
Testing