Add support for search_result objects. #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcr-stripe
force-pushed
the
dcr-search-api
branch
from
3ea647b
to
e6b267c
Compare
dcr-stripe
force-pushed
the
dcr-search-api
branch
from
e6b267c
to
bb48ddd
Compare
richardm-stripe
approved these changes
Jul 23, 2021
Co-authored-by: Richard Marmorstein <[email protected]>
Co-authored-by: Richard Marmorstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
Adds support for generating a
search_resultobject with a single data element, rather than generating an empty result. This is similar tolistbehavior. Assearch_resulthas a slightly different schema, opted for duplicating the logic but happy to merge it in together.This will need the updated OpenAPI spec before we can merge.