Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auBankAccount and BECS debit support #8

Merged
merged 3 commits into from
Feb 13, 2020

Conversation

dweedon-stripe
Copy link
Contributor

Summary & motivation

Add support for the following beta features:

  • auBankAccount Element
  • confirmAuBecsDebitPayment
  • confirmAuBecsDebitSetup
  • au_becs_debit PaymentMethod type

Includes changes from #6

Testing & documentation

Added new type level tests.

Documentation is planned to be included in the beta docs.

@dweedon-stripe
Copy link
Contributor Author

cc @wshallum-stripe: pulled in your changes but added a few more things.

@dweedon-stripe dweedon-stripe changed the title Wshallum/add au bank account Add au bank account and becs debit support Feb 13, 2020
@dweedon-stripe dweedon-stripe changed the title Add au bank account and becs debit support Add auBankAccount and BECS debit support Feb 13, 2020
Copy link
Contributor

@hofman-stripe hofman-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny issues, but looks good overall.

tests/types/index.ts Show resolved Hide resolved
types/stripe-js/elements.d.ts Outdated Show resolved Hide resolved
types/stripe-js/index.d.ts Outdated Show resolved Hide resolved
@dweedon-stripe dweedon-stripe merged commit 4512967 into master Feb 13, 2020
@hofman-stripe hofman-stripe deleted the wshallum/add-au-bank-account branch February 23, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants