Add FPX types #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-stripe
approved these changes
Feb 13, 2020
types/stripe-js/elements.d.ts
Outdated
| */ | ||
| create( | ||
| elementType: 'fpxBank', | ||
| options?: StripeFpxBankElementOptions |
There was a problem hiding this comment.
Suggested change
| options?: StripeFpxBankElementOptions | |
| options: StripeFpxBankElementOptions |
I think options must be passed with at least a accountHolderType field.
| on( | ||
| eventType: 'change', | ||
| handler: (event: StripeFpxBankElementChangeEvent) => any | ||
| ): void; |
There was a problem hiding this comment.
Should this be
Suggested change
| ): void; | |
| ): StripeFpxBankElement; |
? I think so, it looks like the other element types have this wrong too.
There was a problem hiding this comment.
Updating them all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Add the types for the FPX PaymentMethod and the
fpxBankelement.https://stripe.com/docs/js/payment_intents/confirm_fpx_payment
https://stripe.com/docs/js/elements_object/create_element?type=fpxBank
https://stripe.com/docs/payments/fpx#web
Testing & documentation
Documentation is available in the Stripe docs.
I added type level tests.