Added type declarations for BLIK payment. #411
Conversation
|
|
types/stripe-js/payment-intents.d.ts
Outdated
| /** | ||
| * An object containing payment-method-specific configuration to confirm the [PaymentIntent](https://stripe.com/docs/api/payment_intents) with. | ||
| */ | ||
| payment_method_options?: { |
There was a problem hiding this comment.
According to the docs - https://stripe.com/docs/js/payment_intents/confirm_blik_payment#stripe_confirm_blik_payment-data-payment_method_options-code
the following are all required properties - payment_method_options.blik.code so you will need to remove the ?
There was a problem hiding this comment.
Done. Additionally I've also changed data parameter to required in confirmBlikPayment declaration, as it's required in the documentation.
types/stripe-js/stripe.d.ts
Outdated
| @@ -1092,8 +1104,8 @@ export type EphemeralKeyNonceResult = | |||
| | {nonce: string; error?: undefined} | |||
| | {nonce?: undefined; error: StripeError}; | |||
|
|
|||
| /* A Radar Session is a snapshot of the browser metadata and device details that helps Radar make more accurate predictions on your payments. | |||
| This metadata includes information like IP address, browser, screen or device information, and other device characteristics. | |||
| /* A Radar Session is a snapshot of the browser metadata and device details that helps Radar make more accurate predictions on your payments. | |||
There was a problem hiding this comment.
can you revert this change.
michalorman
force-pushed
the
add-confirm-blik-payment-type-declarations
branch
from
307b732 to
a0d22e6
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Summary & motivation
Added type declarations for
confirmBlikPayment(https://stripe.com/docs/js/payment_intents/confirm_blik_payment).Testing & documentation
Added unit tests similar to other payment methods.