Fix StripeException#getUserMessage on v1 API errors #1911
Merged
+80
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This issue #1899 reports that CardException#getUserMessage() returns null after upgrading to SDK v27.1. The root cause is that the underlying StripeError#getUserMessage is only valid for v2 errors. Because it is not present on v1 errors, it will be null in the StripeError object. This PR fixes the issue by ensuring we only access the user message in StripeError for v2 errors.
What
Changelog
StripeError#getUserMessage
to returngetMessage
for errors returned from v1 API calls. This matches pre-v27 behavior for v1 API errors.