Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic_async to PaymentIntent capture method enum #4434

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

yuki-stripe
Copy link
Collaborator

@yuki-stripe yuki-stripe force-pushed the yuki/fix-capture-method-missing-automaticasync branch from ff97595 to 9a0b31e Compare December 24, 2024 22:00
Copy link

github-actions bot commented Dec 24, 2024

⚠️ Public API changes detected:

StripePayments

+ case automaticAsync

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

1 similar comment
Copy link

⚠️ Public API changes detected:

StripePayments

+ case automaticAsync

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@yuki-stripe yuki-stripe merged commit 5ff552b into master Jan 6, 2025
8 of 9 checks passed
@yuki-stripe yuki-stripe deleted the yuki/fix-capture-method-missing-automaticasync branch January 6, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants