Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porter/improve dead code checking #4073

Closed
wants to merge 14 commits into from

Conversation

porter-stripe
Copy link
Collaborator

Summary

Motivation

Testing

Changelog

Copy link

github-actions bot commented Sep 27, 2024

⚠️ Public API changes detected:

Stripe

- @_Concurrency.MainActor(unsafe) @objc convenience dynamic public init()
- @objc(initWithConfiguration:theme:) @_Concurrency.MainActor(unsafe) public init(configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme)
- @objc @_Concurrency.MainActor(unsafe) weak public var delegate: (any Stripe.STPAddCardViewControllerDelegate)?
- @objc @_Concurrency.MainActor(unsafe) public var prefilledInformation: Stripe.STPUserInformation? {
- @objc get
- @objc set
- }
- @objc @_Concurrency.MainActor(unsafe) public var customFooterView: UIKit.UIView? {
- @objc get
- @objc set(footerView)
- }
- @_Concurrency.MainActor(unsafe) public var apiClient: StripeCore.STPAPIClient
- @_Concurrency.MainActor(unsafe) @objc public func tableView(_ tableView: UIKit.UITableView, estimatedHeightForRowAt indexPath: Foundation.IndexPath) -> CoreFoundation.CGFloat
- @_Concurrency.MainActor(unsafe) @objc override dynamic public func viewDidLayoutSubviews()
- @_Concurrency.MainActor(unsafe) @objc public func updateAppearance()
- @_Concurrency.MainActor(unsafe) @objc override dynamic public func viewDidAppear(_ animated: Swift.Bool)
- @_Concurrency.MainActor(unsafe) @objc public func handleCancelTapped(_ sender: Any?)
- @_Concurrency.MainActor(unsafe) @objc public func paymentCardTextFieldDidChange(_ textField: StripePaymentsUI.STPPaymentCardTextField)
- @_Concurrency.MainActor(unsafe) @objc public func paymentCardTextFieldWillEndEditing(forReturn textField: StripePaymentsUI.STPPaymentCardTextField)
- @_Concurrency.MainActor(unsafe) @objc public func paymentCardTextFieldDidBeginEditingCVC(_ textField: StripePaymentsUI.STPPaymentCardTextField)
- @_Concurrency.MainActor(unsafe) @objc public func paymentCardTextFieldDidEndEditingCVC(_ textField: StripePaymentsUI.STPPaymentCardTextField)
- @_Concurrency.MainActor(unsafe) @objc public func paymentCardTextFieldDidBeginEditing(_ textField: StripePaymentsUI.STPPaymentCardTextField)
- @_Concurrency.MainActor(unsafe) @objc public func numberOfSections(in tableView: UIKit.UITableView) -> Swift.Int
- @_Concurrency.MainActor(unsafe) @objc public func tableView(_ tableView: UIKit.UITableView, numberOfRowsInSection section: Swift.Int) -> Swift.Int
- @_Concurrency.MainActor(unsafe) @objc public func tableView(_ tableView: UIKit.UITableView, cellForRowAt indexPath: Foundation.IndexPath) -> UIKit.UITableViewCell
- @_Concurrency.MainActor(unsafe) @objc public func tableView(_ tableView: UIKit.UITableView, willDisplay cell: UIKit.UITableViewCell, forRowAt indexPath: Foundation.IndexPath)
- @_Concurrency.MainActor(unsafe) @objc public func tableView(_ tableView: UIKit.UITableView, heightForFooterInSection section: Swift.Int) -> CoreFoundation.CGFloat
- @_Concurrency.MainActor(unsafe) @objc override public func tableView(_ tableView: UIKit.UITableView, heightForHeaderInSection section: Swift.Int) -> CoreFoundation.CGFloat
- @_Concurrency.MainActor(unsafe) @objc public func tableView(_ tableView: UIKit.UITableView, viewForHeaderInSection section: Swift.Int) -> UIKit.UIView?
- @_Concurrency.MainActor(unsafe) @objc public func tableView(_ tableView: UIKit.UITableView, viewForFooterInSection section: Swift.Int) -> UIKit.UIView?
- @_Concurrency.MainActor(unsafe) @objc override dynamic public func viewWillTransition(to size: CoreFoundation.CGSize, with coordinator: any UIKit.UIViewControllerTransitionCoordinator)
- @objc deinit
- @objc func addCardViewControllerDidCancel(_ addCardViewController: Stripe.STPAddCardViewController)
- @objc func addCardViewController(_ addCardViewController: Stripe.STPAddCardViewController, didCreatePaymentMethod paymentMethod: StripePayments.STPPaymentMethod, completion: @escaping StripePayments.STPErrorBlock)
- @available(*, deprecated, renamed: "addCardViewController(_:didCreatePaymentMethod:completion:)", message: "Use addCardViewController(_:didCreatePaymentMethod:completion:) instead and migrate your integration to PaymentIntents. See https://stripe.com/docs/payments/payment-intents/migration/charges#read")
- @objc optional func addCardViewController(_ addCardViewController: Stripe.STPAddCardViewController, didCreateToken token: StripePayments.STPToken, completion: ((any Swift.Error)?) -> Swift.Void)
- @available(*, deprecated, renamed: "addCardViewController(_:didCreatePaymentMethod:completion:)", message: "Use addCardViewController(_:didCreatePaymentMethod:completion:) instead and migrate your integration to PaymentIntents. See https://stripe.com/docs/payments/payment-intents/migration/charges#read")
- @objc optional func addCardViewController(_ addCardViewController: Stripe.STPAddCardViewController, didCreateSource source: StripePayments.STPSource, completion: ((any Swift.Error)?) -> Swift.Void)
- @objc deinit
- @objc(initWithKeyProvider:) convenience public init(keyProvider: any Stripe.STPCustomerEphemeralKeyProvider)
- @objc(initWithKeyProvider:apiClient:) convenience public init(keyProvider: (any Stripe.STPCustomerEphemeralKeyProvider)?, apiClient: StripeCore.STPAPIClient)
- @objc public func clearCache()
- @objc public var includeApplePayPaymentMethods: Swift.Bool {
- @objc get
- @objc set(includeApplePayMethods)
- }
- @objc public func retrieveCustomer(_ completion: StripePayments.STPCustomerCompletionBlock? = nil)
- @objc public func updateCustomer(withShippingAddress shipping: StripePayments.STPAddress, completion: StripePayments.STPErrorBlock?)
- @objc public func attachPaymentMethodToCustomer(paymentMethodId: Swift.String, completion: StripePayments.STPErrorBlock?)
- @objc public func attachPaymentMethod(toCustomer paymentMethod: StripePayments.STPPaymentMethod, completion: StripePayments.STPErrorBlock?)
- @objc public func detachPaymentMethodFromCustomer(paymentMethodId: Swift.String, completion: StripePayments.STPErrorBlock?)
- @objc public func detachPaymentMethod(fromCustomer paymentMethod: StripePayments.STPPaymentMethod, completion: StripePayments.STPErrorBlock?)
- @objc public func listPaymentMethodsForCustomer(completion: StripePayments.STPPaymentMethodsCompletionBlock? = nil)
- @objc deinit
- @objc convenience public init(customerContext: Stripe.STPCustomerContext)
- @objc convenience public init(customerContext: Stripe.STPCustomerContext, configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme)
- @objc convenience public init(apiAdapter: any Stripe.STPBackendAPIAdapter)
- @objc public init(apiAdapter: any Stripe.STPBackendAPIAdapter, configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme)
- @objc public var apiAdapter: any Stripe.STPBackendAPIAdapter {
- get
- }
- @objc public var configuration: Stripe.STPPaymentConfiguration {
- get
- }
- @objc public var theme: Stripe.STPTheme {
- get
- }
- @objc public var prefilledInformation: Stripe.STPUserInformation? {
- @objc get
- @objc set(prefilledInformation)
- }
- @objc weak public var hostViewController: UIKit.UIViewController? {
- @objc get
- @objc set(hostViewController)
- }
- @objc weak public var delegate: (any Stripe.STPPaymentContextDelegate)? {
- @objc get
- @objc set(delegate)
- }
- @objc public var loading: Swift.Bool {
- @objc get
- }
- @objc public var defaultPaymentMethod: Swift.String?
- @objc public var selectedPaymentOption: (any Stripe.STPPaymentOption)? {
- @objc get
- }
- @objc public var paymentOptions: [any Stripe.STPPaymentOption]? {
- @objc get
- }
- @objc public var selectedShippingMethod: PassKit.PKShippingMethod? {
- get
- }
- @objc public var shippingMethods: [PassKit.PKShippingMethod]? {
- @objc get
- }
- @objc public var shippingAddress: StripePayments.STPAddress? {
- get
- }
- @objc public var paymentAmount: Swift.Int {
- @objc get
- @objc set(paymentAmount)
- }
- @objc public var paymentCurrency: Swift.String
- @objc public var paymentCountry: Swift.String
- @objc public var paymentSummaryItems: [PassKit.PKPaymentSummaryItem] {
- @objc get
- @objc set(paymentSummaryItems)
- }
- @available(macOS 14.0, iOS 17.0, *)
- @objc public var applePayLaterAvailability: PassKit.PKApplePayLaterAvailability {
- @objc get
- @objc set
- }
- @objc public var modalPresentationStyle: UIKit.UIModalPresentationStyle
- @objc public var largeTitleDisplayMode: UIKit.UINavigationItem.LargeTitleDisplayMode
- @objc public var paymentOptionsViewControllerFooterView: UIKit.UIView?
- @objc public var addCardViewControllerFooterView: UIKit.UIView?
- public var apiClient: StripeCore.STPAPIClient {
- get
- set
- }
- @objc public func retryLoading()
- @objc public func presentPaymentOptionsViewController()
- @objc public func pushPaymentOptionsViewController()
- @objc public func presentShippingViewController()
- @objc public func pushShippingViewController()
- @objc public func requestPayment()
- @objc public func paymentOptionsViewController(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController, didSelect paymentOption: any Stripe.STPPaymentOption)
- @objc public func paymentOptionsViewControllerDidFinish(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController)
- @objc public func paymentOptionsViewControllerDidCancel(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController)
- @objc public func paymentOptionsViewController(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController, didFailToLoadWithError error: any Swift.Error)
- @objc public func shippingAddressViewControllerDidCancel(_ addressViewController: Stripe.STPShippingAddressViewController)
- @objc public func shippingAddressViewController(_ addressViewController: Stripe.STPShippingAddressViewController, didEnter address: StripePayments.STPAddress, completion: @escaping Stripe.STPShippingMethodsCompletionBlock)
- @objc public func shippingAddressViewController(_ addressViewController: Stripe.STPShippingAddressViewController, didFinishWith address: StripePayments.STPAddress, shippingMethod method: PassKit.PKShippingMethod?)
- @objc public func authenticationPresentingViewController() -> UIKit.UIViewController
- @objc public func prepare(forPresentation completion: @escaping StripePayments.STPVoidBlock)
- @objc func paymentContext(_ paymentContext: Stripe.STPPaymentContext, didFailToLoadWithError error: any Swift.Error)
- @objc func paymentContextDidChange(_ paymentContext: Stripe.STPPaymentContext)
- @objc func paymentContext(_ paymentContext: Stripe.STPPaymentContext, didCreatePaymentResult paymentResult: Stripe.STPPaymentResult, completion: @escaping StripePayments.STPPaymentStatusBlock)
- @objc func paymentContext(_ paymentContext: Stripe.STPPaymentContext, didFinishWith status: StripePayments.STPPaymentStatus, error: (any Swift.Error)?)
- @objc optional func paymentContext(_ paymentContext: Stripe.STPPaymentContext, didUpdateShippingAddress address: StripePayments.STPAddress, completion: @escaping Stripe.STPShippingMethodsCompletionBlock)
- @objc(initWithPaymentContext:) @_Concurrency.MainActor(unsafe) convenience public init(paymentContext: Stripe.STPPaymentContext)
- @objc(initWithConfiguration:theme:customerContext:delegate:) @_Concurrency.MainActor(unsafe) convenience public init(configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme, customerContext: Stripe.STPCustomerContext, delegate: any Stripe.STPPaymentOptionsViewControllerDelegate)
- @objc(initWithConfiguration:theme:apiAdapter:delegate:) @_Concurrency.MainActor(unsafe) public init(configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme, apiAdapter: any Stripe.STPBackendAPIAdapter, delegate: any Stripe.STPPaymentOptionsViewControllerDelegate)
- @objc @_Concurrency.MainActor(unsafe) public var prefilledInformation: Stripe.STPUserInformation? {
- @objc get
- @objc set
- }
- @objc @_Concurrency.MainActor(unsafe) public var defaultPaymentMethod: Swift.String?
- @objc @_Concurrency.MainActor(unsafe) public var paymentOptionsViewControllerFooterView: UIKit.UIView? {
- @objc get
- @objc set
- }
- @objc @_Concurrency.MainActor(unsafe) public var addCardViewControllerFooterView: UIKit.UIView? {
- @objc get
- @objc set
- }
- @_Concurrency.MainActor(unsafe) public var apiClient: StripeCore.STPAPIClient
- @objc(dismissWithCompletion:) @_Concurrency.MainActor(unsafe) public func dismiss(withCompletion completion: StripePayments.STPVoidBlock?)
- @available(*, unavailable, message: "Use one of the initializers declared in this interface instead.")
- @_Concurrency.MainActor(unsafe) @objc required public init(theme: Stripe.STPTheme?)
- @available(*, unavailable, message: "Use one of the initializers declared in this interface instead.")
- @_Concurrency.MainActor(unsafe) @objc required dynamic public init(nibName nibNameOrNil: Swift.String?, bundle nibBundleOrNil: Foundation.Bundle?)
- @available(*, unavailable, message: "Use one of the initializers declared in this interface instead.")
- @_Concurrency.MainActor(unsafe) @objc required dynamic public init?(coder aDecoder: Foundation.NSCoder)
- @_Concurrency.MainActor(unsafe) @objc override dynamic public func viewDidLayoutSubviews()
- @_Concurrency.MainActor(unsafe) @objc override dynamic public func viewDidAppear(_ animated: Swift.Bool)
- @_Concurrency.MainActor(unsafe) @objc public func addCardViewControllerDidCancel(_ addCardViewController: Stripe.STPAddCardViewController)
- @_Concurrency.MainActor(unsafe) @objc public func addCardViewController(_ addCardViewController: Stripe.STPAddCardViewController, didCreatePaymentMethod paymentMethod: StripePayments.STPPaymentMethod, completion: @escaping StripePayments.STPErrorBlock)
- @objc deinit
- @objc func paymentOptionsViewController(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController, didFailToLoadWithError error: any Swift.Error)
- @objc func paymentOptionsViewControllerDidFinish(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController)
- @objc func paymentOptionsViewControllerDidCancel(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController)
- @objc(paymentOptionsViewController:didSelectPaymentOption:) optional func paymentOptionsViewController(_ paymentOptionsViewController: Stripe.STPPaymentOptionsViewController, didSelect paymentOption: any Stripe.STPPaymentOption)
- @_Concurrency.MainActor(unsafe) @objc convenience dynamic public init()
- @objc(initWithPaymentContext:) @_Concurrency.MainActor(unsafe) convenience public init(paymentContext: Stripe.STPPaymentContext)
- @objc(initWithConfiguration:theme:currency:shippingAddress:selectedShippingMethod:prefilledInformation:) @_Concurrency.MainActor(unsafe) public init(configuration: Stripe.STPPaymentConfiguration, theme: Stripe.STPTheme, currency: Swift.String?, shippingAddress: StripePayments.STPAddress?, selectedShippingMethod: PassKit.PKShippingMethod?, prefilledInformation: Stripe.STPUserInformation?)
- @objc @_Concurrency.MainActor(unsafe) weak public var delegate: (any Stripe.STPShippingAddressViewControllerDelegate)?
- @objc(dismissWithCompletion:) @_Concurrency.MainActor(unsafe) public func dismiss(withCompletion completion: StripePayments.STPVoidBlock?)
- @available(*, unavailable, message: "Use one of the initializers declared in this interface instead.")
- @_Concurrency.MainActor(unsafe) @objc required public init(theme: Stripe.STPTheme?)
- @available(*, unavailable, message: "Use one of the initializers declared in this interface instead.")
- @_Concurrency.MainActor(unsafe) @objc required dynamic public init(nibName nibNameOrNil: Swift.String?, bundle nibBundleOrNil: Foundation.Bundle?)
- @_Concurrency.MainActor(unsafe) @objc override dynamic public func viewDidAppear(_ animated: Swift.Bool)
- @_Concurrency.MainActor(unsafe) @objc override public func tableView(_ tableView: UIKit.UITableView, heightForHeaderInSection section: Swift.Int) -> CoreFoundation.CGFloat
- @objc deinit
- @objc func shippingAddressViewControllerDidCancel(_ addressViewController: Stripe.STPShippingAddressViewController)
- @objc(shippingAddressViewController:didEnterAddress:completion:) func shippingAddressViewController(_ addressViewController: Stripe.STPShippingAddressViewController, didEnter address: StripePayments.STPAddress, completion: @escaping Stripe.STPShippingMethodsCompletionBlock)
- @objc(shippingAddressViewController:didFinishWithAddress:shippingMethod:) func shippingAddressViewController(_ addressViewController: Stripe.STPShippingAddressViewController, didFinishWith address: StripePayments.STPAddress, shippingMethod method: PassKit.PKShippingMethod?)
- @_Concurrency.MainActor(unsafe) @objc dynamic public func numberOfSections(in tableView: UIKit.UITableView) -> Swift.Int
- @_Concurrency.MainActor(unsafe) @objc dynamic public func tableView(_ tableView: UIKit.UITableView, numberOfRowsInSection section: Swift.Int) -> Swift.Int
- @_Concurrency.MainActor(unsafe) @objc dynamic public func tableView(_ tableView: UIKit.UITableView, cellForRowAt indexPath: Foundation.IndexPath) -> UIKit.UITableViewCell
- @_Concurrency.MainActor(unsafe) @objc dynamic public func tableView(_ tableView: UIKit.UITableView, willDisplay cell: UIKit.UITableViewCell, forRowAt indexPath: Foundation.IndexPath)
- @_Concurrency.MainActor(unsafe) @objc dynamic public func tableView(_ tableView: UIKit.UITableView, heightForFooterInSection section: Swift.Int) -> CoreFoundation.CGFloat
- @_Concurrency.MainActor(unsafe) @objc dynamic public func tableView(_ tableView: UIKit.UITableView, viewForFooterInSection section: Swift.Int) -> UIKit.UIView?
- @_Concurrency.MainActor(unsafe) @objc dynamic public func tableView(_ tableView: UIKit.UITableView, viewForHeaderInSection section: Swift.Int) -> UIKit.UIView?

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

Copy link

emerge-tools bot commented Sep 27, 2024

⚠️ 1 new unused protocol, 1 build decreased size, 5 builds had no size change

Name Version Download Change Install Change Approval
StripeApplePaySize
com.stripe.StripeApplePaySize
1.0 (1) 432.5 kB - 1.5 MB - N/A
StripeSize
com.stripe.StripeSize
1.0 (1) 2.3 MB ⬇️ 117.8 kB (-4.92%) 7.5 MB ⬇️ 317.4 kB (-4.08%) N/A
StripeFinancialConnectionsSize
com.stripe.StripeFinancialConnectionsSize
1.0 (1) 1.3 MB ⬇️ 2 B 4.3 MB - N/A
StripePaymentsSize
com.stripe.StripePaymentsSize
1.0 (1) 1.1 MB ⬇️ 1 B 4.1 MB - N/A
StripePaymentsUISize
com.stripe.StripePaymentsUISize
1.0 (1) 1.9 MB ⬆️ 2 B 6.3 MB - N/A
StripePaymentSheetSize
com.stripe.StripePaymentSheetSize
1.0 (1) 3.4 MB ⬆️ 11 B 10.2 MB - N/A

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

No changes to report

StripeSize 1.0 (1)
com.stripe.StripeSize

⚠️ Found new unused protocol: STPAddressViewModelDelegate
⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 317.4 kB (-4.08%)
Total download size change: ⬇️ 117.8 kB (-4.92%)

Largest size changes

Item Install Size Change
🗑 Stripe.STPPaymentContext ⬇️ -49.2 kB
🗑 Stripe.STPAddCardViewController ⬇️ -36.9 kB
🗑 Stripe.STPShippingAddressViewController ⬇️ -24.2 kB
🗑 Stripe.STPPaymentOptionsViewController ⬇️ -22.7 kB
🗑 Stripe.STPPaymentOptionsInternalViewController ⬇️ -21.3 kB
View Treemap

Image of diff

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

No changes to report

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

No changes to report

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

No changes to report

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

No changes to report


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

Copy link

github-actions bot commented Sep 28, 2024

🚨 New dead code detected in this PR:

PKPaymentAuthorizationViewController+Stripe_Blocks.swift: warning: Function 'stp_controller(with:apiClient:onShippingAddressSelection:onShippingMethodSelection:onPaymentAuthorization:onPaymentMethodCreation:onFinish:)' is unused
PKPaymentAuthorizationViewController+Stripe_Blocks.swift: warning: Property 'kSTPBlockBasedApplePayDelegateAssociatedObjectKey' is unused
STPAPIClient+BasicUI.swift: warning: Function 'updateCustomer(withParameters:using:completion:)' is unused
STPAPIClient+BasicUI.swift: warning: Function 'attachPaymentMethod(_:toCustomerUsing:completion:)' is unused
STPAPIClient+BasicUI.swift: warning: Function 'detachPaymentMethod(_:fromCustomerUsing:completion:)' is unused
STPAPIClient+BasicUI.swift: warning: Function 'listPaymentMethodsForCustomer(using:completion:)' is unused
STPAPIClient+BasicUI.swift: warning: Function 'retrieveCustomer(using:completion:)' is unused
STPAddressViewModel.swift: warning: Property 'address' is unused
STPAddressViewModel.swift: warning: Property 'isValid' is unused
STPAddressViewModel.swift: warning: Initializer 'init(requiredBillingFields:availableCountries:)' is unused
STPAddressViewModel.swift: warning: Initializer 'init(requiredShippingFields:availableCountries:)' is unused
STPAddressViewModel.swift: warning: Function 'commonInit()' is unused
STPCameraView.swift: warning: Property 'captureSession' is unused
STPCardScanner.swift: warning: Enum 'STPCardScannerError' is unused
STPCardScanner.swift: warning: Property 'cardScanningAvailableCameraHasUsageDescription' is unused
STPCardScanner.swift: warning: Property 'cardScanningAvailable' is unused
STPCardScanner.swift: warning: Property 'feedbackGenerator' is unused
STPCardScanner.swift: warning: Initializer 'init(delegate:)' is unused
STPCardScanner.swift: warning: Function 'start()' is unused
STPCardScanner.swift: warning: Function 'stop()' is unused
STPCardScanner.swift: warning: Property 'delegate' is unused
STPCardScanner.swift: warning: Property 'captureSessionQueue' is unused
STPCardScanner.swift: warning: Property 'timeoutTime' is unused
STPCardScanner.swift: warning: Property 'startTime' is unused
STPCardScanner.swift: warning: Function 'stp_cardScanningError()' is unused
STPCardScanner.swift: warning: Function 'stopWithError(_:)' is unused
STPCardScanner.swift: warning: Function 'finish(with:error:)' is unused
STPCardScanner.swift: warning: Property 'STPCardScannerErrorDomain' is unused
STPCardScannerTableViewCell.swift: warning: Class 'STPCardScannerTableViewCell' is unused
STPCoreViewController.swift: warning: Function 'useSystemBackButton()' is unused
STPPaymentCardTextFieldCell.swift: warning: Class 'STPPaymentCardTextFieldCell' is unused
STPPaymentContextAmountModel.swift: warning: Class 'STPPaymentContextAmountModel' is unused
STPPaymentOptionTableViewCell.swift: warning: Class 'STPPaymentOptionTableViewCell' is unused
STPPaymentOptionTuple.swift: warning: Class 'STPPaymentOptionTuple' is unused
STPSectionHeaderView.swift: warning: Class 'STPSectionHeaderView' is unused
STPShippingMethodTableViewCell.swift: warning: Class 'STPShippingMethodTableViewCell' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants