Update embedded appearance API and add to playground #4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
reviewed
Sep 27, 2024
| @@ -6,7 +6,7 @@ | |||
| // Copyright © 2022 stripe-ios. All rights reserved. | |||
| // | |||
|
|
|||
| @_spi(STP) import StripePaymentSheet | |||
| @_spi(STP) @_spi(EmbeddedPaymentElementPrivateBeta) import StripePaymentSheet | |||
There was a problem hiding this comment.
Can we remove (STP)? Leaving it risks not noticing if we break visibility of an API.
| @@ -237,6 +284,7 @@ struct AppearancePlaygroundView: View { | |||
| Section(header: Text("Miscellaneous")) { | |||
| Stepper(String(format: "cornerRadius: %.1f", appearance.cornerRadius), value: cornerRadiusBinding, in: 0...30) | |||
| Stepper(String(format: "borderWidth: %.1f", appearance.borderWidth), value: borderWidthBinding, in: 0.0...2.0, step: 0.5) | |||
| Stepper(String(format: "selectedBorderWidth: %.1f", appearance.selectedBorderWidth ?? appearance.borderWidth * 1.5), value: borderWidthBinding, in: 0.0...2.0, step: 0.5) | |||
There was a problem hiding this comment.
Suggested change
| Stepper(String(format: "selectedBorderWidth: %.1f", appearance.selectedBorderWidth ?? appearance.borderWidth * 1.5), value: borderWidthBinding, in: 0.0...2.0, step: 0.5) | |
| Stepper(String(format: "selectedBorderWidth: %.1f", appearance.selectedBorderWidth ?? appearance.borderWidth * 1.5), value: selectedBorderWidthBinding, in: 0.0...2.0, step: 0.5) |
right?
There was a problem hiding this comment.
ah good eye!
Comment on lines
278
to
279
| /// The insets of the separator line between rows | ||
| public var separatorInsets: UIEdgeInsets? |
There was a problem hiding this comment.
Let's add a note about behavior when nil.
yuki-stripe
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simulator.Screen.Recording.-.iOS.18.-.2024-09-26.at.09.41.56.mp4
Motivation
Testing
Changelog
N/A