[Connect] Add Dashboard-only access to NotificationBanner #4061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_dashboard_components
branch
from
dd968f0 to
e844c0f
Compare
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_notification_banner
branch
from
2c98ef3 to
b00b9bd
Compare
|
🚨 New dead code detected in this PR: NotificationBannerViewController.swift: warning: Property 'collectionOptions' is assigned, but never usedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_dashboard_components
branch
2 times, most recently
from
13b9949 to
a272b52
Compare
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_notification_banner
branch
2 times, most recently
from
baf7731 to
c04f948
Compare
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_dashboard_components
branch
from
a272b52 to
62516e2
Compare
Base automatically changed from
mludowise/MXMOBILE-2503_dashboard_components
to
master
October 2, 2024 19:33
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_notification_banner
branch
from
6f39d37 to
19b7736
Compare
mludowise-stripe
changed the title
|
Dead code check has a false positive because it's not checking if the property is used in an Encodable |
mludowise-stripe
commented
Oct 2, 2024
| @@ -9,7 +9,7 @@ import Foundation | |||
|
|
|||
| @_spi(PrivateBetaConnect) | |||
| /// Collection options for account onboarding | |||
| public struct AccountCollectionOptions: Codable { | |||
| public struct AccountCollectionOptions: Equatable, Codable { | |||
There was a problem hiding this comment.
Added Equatable so we could compare values in the Dashboard app
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_notification_banner
branch
from
0c10880 to
bb8a81d
Compare
nschris-stripe
approved these changes
Oct 4, 2024
mludowise-stripe
deleted the
mludowise/MXMOBILE-2503_notification_banner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
NotificationBannerViewControllerequivalent to the Notification banner embedded component with DashboardOnly access.This component has a delegate callback,
didChangeWithTotal: andActionRequiredwhich contains:Motivation
https://jira.corp.stripe.com/browse/MXMOBILE-2503
Testing
Unit tests