[Connect] Fix API inconsistent naming + Add Dashboard-only support for Account Management component #4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2502_uk_connect
branch
from
1802618 to
cf3cbc1
Compare
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_dashboard_components
branch
from
990be64 to
d639757
Compare
Base automatically changed from
mludowise/MXMOBILE-2502_uk_connect
to
master
September 24, 2024 03:12
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_dashboard_components
branch
from
d639757 to
fc2d6f3
Compare
mludowise-stripe
changed the title
mludowise-stripe
changed the title
mludowise-stripe
changed the title
mludowise-stripe
changed the title
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_dashboard_components
branch
from
fc2d6f3 to
efe90a3
Compare
Comment on lines
+57
to
+58
| func payouts(_ payouts: PayoutsViewController, | ||
| didFailLoadWithError error: Error) |
There was a problem hiding this comment.
We had intended to make this consistent with the AccountOnboarding delegate style, but it slipped past API review. Paper trail of API approval:
https://docs.google.com/document/d/195BaU6k2J-2CAs9anNE6e4OlZO34N-e2HTYc6pacpTw/edit?pli=1#bookmark=id.dk457iw2wtca
| @@ -98,6 +98,13 @@ public class EmbeddedComponentManager { | |||
| .init(componentManager: self) | |||
| } | |||
|
|
|||
| @_spi(DashboardOnly) | |||
| public func createAccountManagementViewController( | |||
| collectionOptions: AccountCollectionOptions = .init()) -> AccountManagementViewController { | |||
There was a problem hiding this comment.
not sure yet whether we plan to set account collection options or whether this does anything for Dashboard, but putting it in for now so we can test it
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_dashboard_components
branch
from
dd968f0 to
e844c0f
Compare
|
🚨 New dead code detected in this PR: AccountManagementViewController.swift: warning: Property 'collectionOptions' is assigned, but never usedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_dashboard_components
branch
from
e844c0f to
13b9949
Compare
mludowise-stripe
changed the base branch from
master
to
mludowise/MXMOBILE-2796_onboarding_properties
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_dashboard_components
branch
from
13b9949 to
a272b52
Compare
Base automatically changed from
mludowise/MXMOBILE-2796_onboarding_properties
to
master
September 30, 2024 22:11
mludowise-stripe
force-pushed
the
mludowise/MXMOBILE-2503_dashboard_components
branch
from
a272b52 to
62516e2
Compare
|
Dead code check has a false positive – adding label |
nschris-stripe
previously approved these changes
Oct 2, 2024
StripeConnect/StripeConnect/Source/Components/ComponentType.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Mays <[email protected]>
nschris-stripe
approved these changes
Oct 2, 2024
mludowise-stripe
deleted the
mludowise/MXMOBILE-2503_dashboard_components
branch
porter-stripe
added a commit
that referenced
this pull request
Oct 3, 2024
## Summary - Includes line numbers in the dead code check - Retains `Codable` properties in dead code check (#4036 (comment)) - Better format API diff output ## Motivation Improve CI ## Testing #4088 ## Changelog N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the account management component with DashboardOnly access
Fixes inconsistent delegate naming in PayoutsViewController
The account onboarding component had a delegate signature of:
However, the payouts component was using:
During API review, we had intended to use the account onboarding style signature (see papertrail)
Motivation
https://jira.corp.stripe.com/browse/MXMOBILE-2503
Testing
Unit tests