Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connect] Prepare to publish StripeConnect module #4035
[Connect] Prepare to publish StripeConnect module #4035
Changes from 9 commits
f311611
3a1a591
a0ee189
b40706f
0f9ca77
ee0688e
fd953d8
b23c639
5bde8d8
cf09a35
43cf6f3
5c8bba6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set these to "Do not embed" per runbook:
https://confluence.corp.stripe.com/display/MOBILE/iOS+SDK+Runbook%3A+Adding+module+dependencies#iOSSDKRunbook:Addingmoduledependencies-1.Configurepackagemanagers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The supported min version is now 13.0, so no need for these checks anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Connect assertion fails if the app doesn't configure this, so this has been added to all installation test projects