Add embedded to playground #4025
Conversation
| } set: { newUIStyle in | ||
| // If we switch to embedded put style back to vertical and default back to deferred CSC if we are in an intent first integration | ||
| if newUIStyle == .embedded { | ||
| playgroundController.settings.layout = .vertical |
There was a problem hiding this comment.
Even though embedded doesn't use this layout API, I think it makes the most sense to change the toggle to vertical as that's what most resembles embedded.
There was a problem hiding this comment.
Is it possible to disable the inapplicable toggles rather than changing their selection?
There was a problem hiding this comment.
Ah yes, easier than I anticipated! I left the logic for changing the confirmation type but now also disable it. I think it makes sense that it always goes back to deferred CSC, then disabling.
There was a problem hiding this comment.
Switching normal -> deferred_csc makes sense.
IMO I don't want it to switch to .vertical though; that's more confusing than helpful since the value is ignored either way. It should just stay whatever value it was.
There was a problem hiding this comment.
🤦 I agree, I thought I had removed that but clearly didn't. Fixed!
Summary
Simulator.Screen.Recording.-.iOS.18.-.2024-09-17.at.11.49.45.mp4
Motivation
Testing
Changelog
N/A