Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical mode "New card" special casing #3717

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Conversation

yuki-stripe
Copy link
Collaborator

Summary

Bunch of "new card" special casing

  • Position cards first in list if saved PM is a card
  • Use "New Card" in vertical payment method row if saved PM is a card
  • Fix "New card" form title if saved PM is a card.

Also:

  • Delete VerticalPaymentSheetViewControllerSnapshotTest.swift, this is dead code (the file was renamed to PaymentSheetVerticalViewControllerSnapshotTest.swift)

Motivation

https://docs.google.com/document/d/1tRLvYH4_UzRGevJuP15gU4SlU5zt9_pJBZtiOSMxy6A/edit

Testing

See snapshot tests

@yuki-stripe yuki-stripe requested review from a team as code owners June 26, 2024 23:18
@yuki-stripe yuki-stripe changed the title Yuki/vertical new card Vertical mode "New card" special casing Jun 26, 2024
Copy link

github-actions bot commented Jun 26, 2024

⚠️ Missing Translations
The following strings have been uploaded to Lokalise but are not yet translated.

New card

If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label ship without translations to acknowledge that there are missing translations. Otherwise, wait until translations are available in Lokalise and re-run this job.

New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link.

@yuki-stripe yuki-stripe merged commit 0bfb2a3 into master Jun 27, 2024
5 checks passed
@yuki-stripe yuki-stripe deleted the yuki/vertical-new-card branch June 27, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants