Add DefaultSettings to Subscription Schedules #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
requested changes
Nov 5, 2019
subschedule.go
Outdated
| AmountGTE int64 `json:"amount_gte"` | ||
| ResetBillingCycleAnchor bool `json:"reset_billing_cycle_anchor"` | ||
| } | ||
|
|
There was a problem hiding this comment.
This should not be here. Sharing was done before and used the subscription's one SubscriptionBillingThresholdsParams and sharing is what the spec says to do (and what java does). Si you should remove that class and use SubscriptionBillingThresholdsParams instead.
subschedule.go
Outdated
| // SubscriptionScheduleDefaultSettings is a structure representing the | ||
| // subscription schedule’s default settings. | ||
| type SubscriptionScheduleDefaultSettings struct { | ||
| BillingThresholds *SubscriptionScheduleBillingThresholds `json:"billing_thresholds"` |
There was a problem hiding this comment.
same as above. That class should not be here
subschedule.go
Outdated
| Params `form:"*"` | ||
| Customer *string `form:"customer"` | ||
| DefaultSettings *SubscriptionScheduleDefaultSettingsParams `form:"default_settings"` | ||
| DefaultSource *string `form:"default_source"` |
There was a problem hiding this comment.
you should remove DefaultSource
|
Looked and compared with stripe-dotnet and the changes lgtm. Assigning to @ob-stripe for final review. |
remi-stripe
assigned ob-stripe and brandur-stripe and unassigned cjavilla-stripe and ob-stripe
brandur-stripe
approved these changes
Nov 5, 2019
nadaismail-stripe
added a commit
that referenced
this pull request
Oct 18, 2024
nadaismail-stripe
added a commit
that referenced
this pull request
Oct 18, 2024
* added caching service to mapper * added integer to list * merged in main and cleaned up PR * more cleanup * reverted class change * silenced CI failures for mapper * updated git ignore * Sanitize duration_in_months always (#985) * Support amending orders with coupons (#956) * Productionize coupon order trigger (#934) * Ensure updateCoupons trigger is deterministic (#988) * Update 'add_invoice_items.period.end.type' on proration invoices (#987) * Backend proration with amendment (#847) * Add class access for coupon handler (#990) * Manual Translation in Sync Preferences (#992) * passing in mapper to amendment funcs * removed extra backoff * return empty list for non supported cache types --------- Co-authored-by: Nada Ismail <[email protected]> Co-authored-by: jmather-c <[email protected]> Co-authored-by: mbianco-stripe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries
Updates API version to:
2019-11-05Updates stripe-mock minimum version to
0.71.0Adds:
DefaultSettingswithBillingThresholds,CollectionMethod,DefaultPaymentMethod,InvoiceSettingstoSubscriptionScheduleRemoves:
BillingThresholds,CollectionMethod,DefaultPaymentMethod,DefaultSource,InvoiceSettingsfromSubscriptionSchedule