Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Account field to BankAccount #966

Merged
merged 2 commits into from
Oct 3, 2019
Merged

Add the Account field to BankAccount #966

merged 2 commits into from
Oct 3, 2019

Conversation

pauldemarco
Copy link
Contributor

@pauldemarco pauldemarco commented Oct 2, 2019

This change adds the already present (network-wise) Account field to the BankAccount struct, and allows the BankAccount to become self contained --no longer needing to tuple an Event struct alongside the BankAccount when handling webhooks.

Tested working for sc.BankAccounts.New and when responding to a account.external_account.updated event in a webhook.

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for starting the work here! I left a comment as something needs to be changed before we can merge!

bankaccount.go Outdated Show resolved Hide resolved
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick change, and for doing all the work!

@remi-stripe remi-stripe merged commit 7cc5f5d into stripe:master Oct 3, 2019
@pauldemarco pauldemarco deleted the bank_account_fix_965 branch October 3, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants