Remi remove todos #962
Merged
Remi remove todos #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed `GetBalanceTransaction` and `List` from the `balance` package. Prefer using `Get` and `List` in the `balancetransaction` package. * Removed `ApplicationFee` from the `charge` and `paymentintent` packages. Prefer using `ApplicationFeeAmount`. * Removed `TaxInfo` and related fields from the `customer` packager. Prefer using the `customertaxid` package. * Removed unsupported `Customer` parameter on `PaymentMethodParams` and `PaymentMethodDetachParams` in the `paymentmethod` package. * Removed `Billing` properties in the `invoice`, `sub` and `subschedule` packages. Prefer using `CollectionMethod`. * Removed the `InvoiceBilling` type from the `invoice` package. Prefer using `InvoiceCollectionMethod`. * Removed the `SubscriptionBilling` type from the `sub` package. Prefer using `SubscriptionCollectionMethod`. * Removed deprecated constants for `PaymentIntentConfirmationMethod` in `paymentintent` package. * Removed `OperatorAccount` from Terminal APIs. *
ob-stripe
approved these changes
Sep 25, 2019
payout.go
Outdated
| // object when retrieving | ||
| func (d *PayoutDestination) MarshalJSON() ([]byte, error) { | ||
| return json.Marshal(d.ID) | ||
| } |
There was a problem hiding this comment.
Why is this no longer needed?
There was a problem hiding this comment.
This was done by brandur for another issue/PR but I had the wrong base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove TODOs and deprecated parts
GetBalanceTransactionandListfrom thebalancepackage. Prefer usingGetandListin thebalancetransactionpackage.ApplicationFeefrom thechargeandpaymentintentpackages. Prefer usingApplicationFeeAmount.TaxInfoand related fields from thecustomerpackager. Prefer using thecustomertaxidpackage.Customerparameter onPaymentMethodParamsandPaymentMethodDetachParamsin thepaymentmethodpackage.Billingproperties in theinvoice,subandsubschedulepackages. Prefer usingCollectionMethod.InvoiceBillingtype from theinvoicepackage. Prefer usingInvoiceCollectionMethod.SubscriptionBillingtype from thesubpackage. Prefer usingSubscriptionCollectionMethod.PaymentIntentConfirmationMethodinpaymentintentpackage.OperatorAccountfrom Terminal APIs.r? @ob-stripe
cc @stripe/api-libraries