Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FPX PaymentMethod Support #955

Merged
merged 7 commits into from
Oct 3, 2019
Merged

Conversation

shengwei-stripe
Copy link
Contributor

@remi-stripe @ob-stripe
Add Fpx PaymentMethod Support

cc @stripe/api-libraries

charge.go Outdated Show resolved Hide resolved
paymentmethod.go Outdated Show resolved Hide resolved
paymentmethod.go Outdated Show resolved Hide resolved
paymentmethod.go Outdated Show resolved Hide resolved
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment + you have a linter error in the test suite

Also you need to rename all Fpx to FPX instead for consistency per discussion on Slack internally. It was a mistake to not do this on SEPA and ACH unfortunately.

charge.go Outdated Show resolved Hide resolved
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also have a build error here too so make sure to fix that one!

charge.go Outdated Show resolved Hide resolved
paymentmethod.go Outdated Show resolved Hide resolved
paymentmethod.go Outdated Show resolved Hide resolved
@shengwei-stripe
Copy link
Contributor Author

@remi-stripe done, finger crossed. Thanks for the review.

paymentmethod.go Outdated Show resolved Hide resolved
paymentmethod.go Outdated Show resolved Hide resolved
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all the work @shengwei-stripe and for the patience with all my feedback

@remi-stripe remi-stripe merged commit 6ea4095 into stripe:master Oct 3, 2019
nadaismail-stripe added a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants