-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FPX PaymentMethod Support #955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment + you have a linter error in the test suite
Also you need to rename all Fpx
to FPX
instead for consistency per discussion on Slack internally. It was a mistake to not do this on SEPA and ACH unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also have a build error here too so make sure to fix that one!
@remi-stripe done, finger crossed. Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing all the work @shengwei-stripe and for the patience with all my feedback
@remi-stripe @ob-stripe
Add Fpx PaymentMethod Support
cc @stripe/api-libraries