Move to API version 2019-08-14 and other changes #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-2019-08-14
branch
from
2f0690b to
96e847a
Compare
ob-stripe
suggested changes
Aug 14, 2019
remi-stripe
force-pushed
the
remi-2019-08-14
branch
from
96e847a to
4a75956
Compare
|
LGTM! Love the various cleanups here. Reassigning to @brandur-stripe for a second look just in case. |
ob-stripe
requested review from
ob-stripe and
brandur-stripe
and removed request for
ob-stripe
There was a problem hiding this comment.
One comment, but LGTM Remi! Thanks for remembering that all these TODOs even existed.
ptal @remi-stripe
| @@ -242,7 +219,7 @@ type PaymentIntent struct { | |||
| Customer *Customer `json:"customer"` | |||
| Description string `json:"description"` | |||
| Invoice *Invoice `json:"invoice"` | |||
| LastPaymentError *PaymentIntentLastPaymentError `json:"last_payment_error"` | |||
| LastPaymentError *Error `json:"last_payment_error"` | |||
There was a problem hiding this comment.
Just flagging that it looks like DocURL will go away with this change. I think it may just be an oversight that it's not on the standard Error struct?
There was a problem hiding this comment.
Damn nice catch, yes looks like an oversight, let me add this
remi-stripe
force-pushed
the
remi-2019-08-14
branch
from
4a75956 to
10bbc4f
Compare
brandur-stripe
approved these changes
Aug 15, 2019
remi-stripe
force-pushed
the
remi-2019-08-14
branch
from
10bbc4f to
f063d15
Compare
ob-stripe
approved these changes
Aug 15, 2019
* Pin to API version 2019-08-14 * Rename AccountCapabilityPlatformPayments to AccountCapabilityTransfers * Add `Executive` in `PersonRelationship` * Remove `PayentMethodOptions` as there was a typo which was fixed. * Make `OffSession` only support booleans on `PaymentIntent` * Remove `PaymentIntentLastPaymentError` and use `Error` instead * Move `DeclineCode` on `Error` to the `DeclineCode` instead of `string`
remi-stripe
force-pushed
the
remi-2019-08-14
branch
from
f063d15 to
30f0381
Compare
|
Released as 62.0.0. |
nadaismail-stripe
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecutiveinPersonRelationshipPayentMethodOptionsas there was a typo which was fixed.OffSessiononly support booleans onPaymentIntentPaymentIntentLastPaymentErrorand useErrorinsteadDeclineCodeonErrorto theDeclineCodeinstead ofstringr? @ob-stripe @brandur-stripe (tagging you both are there are multiple changes
cc @stripe/api-libraries