Disable HTTP/2 by default #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #866, but once in a while when using HTTP/2, stripe-go sends an empty request body which then results in a 400 back from the server. We tracked the issue down to this one open on the Go language's HTTP/2 implementation: golang/go#32441 For now, the best thing we can do is disable HTTP/2 by default for new integrations. When the bug is fixed, we can turn it back on again.
| // | ||
| // https://github.com/golang/go/issues/32441 | ||
| // | ||
| // This is particularly problematic for this library because the empty body |
There was a problem hiding this comment.
Great comment; thanks for capturing all the context in here. It's my sincere hope that we can re-enable H/2 support soon, when that Go issue gets addressed.
There was a problem hiding this comment.
Thanks! And yep, totally +1.
dcarney-stripe
approved these changes
Jul 25, 2019
|
Thanks Dylan! |
|
Released as 61.20.0. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
… debugging (#903) * Added some readme documentation, and some dev support items for local debugging * Fix build error * Fix build error take 2 * Sorbet is fun * Update spring.rb More fun with sorbet. * Update spring.rb Even more Sorbet fun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #866, but once in a while when using HTTP/2, stripe-go sends an
empty request body which then results in a 400 back from the server.
We tracked the issue down to this one open on the Go language's HTTP/2
implementation:
golang/go#32441
For now, the best thing we can do is disable HTTP/2 by default for new
integrations. When the bug is fixed, we can turn it back on again.
r? @dcarney-stripe
cc @stripe/api-libraries