Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OffSession to SubscriptionItem update #899

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

remi-stripe
Copy link
Contributor

r? @ob-stripe
cc @stripe/api-libraries

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit on the comment above, but lgtm

subitem.go Outdated
@@ -15,6 +15,7 @@ type SubscriptionItemParams struct {
TaxRates []*string `form:"tax_rates"`

// The following parameter is only supported on updates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// The following parameter is only supported on updates
// The following parameters are only supported on updates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, fixed.

@remi-stripe remi-stripe force-pushed the remi-add-off-session-si branch from d2c34a9 to 0b9ddb5 Compare July 19, 2019 16:37
@remi-stripe remi-stripe merged commit bf02fc7 into master Jul 19, 2019
@remi-stripe remi-stripe deleted the remi-add-off-session-si branch July 19, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants