Add all missing error codes #897
Conversation
remi-stripe
force-pushed
the
remi-add-error-codes
branch
from
0327084 to
ea782af
Compare
error.go
Outdated
|
|
||
| // The following error codes can be returned though are undocumented | ||
| ErrorCodeIncorrectCVC ErrorCode = "incorrect_cvc" | ||
| ErrorCodeInvalidCVC ErrorCode = "invalid_cvc" |
There was a problem hiding this comment.
I have no idea how this is even working, but both ErrorCodeIncorrectCVC and ErrorCodeInvalidCVC are already defined (with the same values) above.
There was a problem hiding this comment.
Hah, the case is different on "Cvc" (versus "CVC"). Might be a good idea to change the ones above to upper too.
remi-stripe
force-pushed
the
remi-add-error-codes
branch
from
ea782af to
4887a3f
Compare
remi-stripe
force-pushed
the
remi-add-error-codes
branch
from
4887a3f to
fb83880
Compare
|
Re-assigning to @brandur-stripe as we never finished that one |
remi-stripe
force-pushed
the
remi-add-error-codes
branch
from
fb83880 to
da68337
Compare
remi-stripe
force-pushed
the
remi-add-error-codes
branch
from
da68337 to
16139b5
Compare
| ErrorCodeResourceMissing ErrorCode = "resource_missing" | ||
| ErrorCodeRoutingNumberInvalid ErrorCode = "routing_number_invalid" | ||
| ErrorCodeSecretKeyRequired ErrorCode = "secret_key_required" | ||
| ErrorCodeSepaUnsupportedAccount ErrorCode = "sepa_unsupported_account" |
There was a problem hiding this comment.
Last one Remi: I think we want to go with "SEPA" instead of "Sepa" here.
There was a problem hiding this comment.
We use Sepa everywhere else in the library though for SepaDebit. I don't think we should change that one but happy to make the change if you prefer on that one
There was a problem hiding this comment.
Ah, k. I looked around online and I think "SEPA" is definitely the overall preferred casing (and use in Stripe's docs, etc. too).
That said, given we have pre-existing Sepa in stripe-go, I'm good just keeping it like this for consistency.
There was a problem hiding this comment.
Yeah, I'm unsure on that one, I think both would make sense so deferring to you but happy to make the change
There was a problem hiding this comment.
K cool. Easiest to go with "Sepa" for now then, so just leave it. Thanks!
|
One more casing issue, but other than that LGTM! Love how comprehensive this list is. ptal @remi-stripe |
|
Released as 61.20.0. |
|
|
|
@layby42 Would you have a bit more details than just this code? It's not listed in https://stripe.com/docs/error-codes today which is why it wasn't added. I'd recommend flagging to our support team if it's a code you rely on: https://support.stripe.com/contact |
|
@remi-stripe happens when you try to pay invoice (Invoices.Pay) for "incomplete" subscription with card payment method (stripe.InvoicePayParams -> PaymentMethod) that requires 3D Secure authorization on attempt to charge. Also (not directly related) would be nice to get Invoice from stripe.Error (the way it is possible to get PaymentIntent or PaymentMethod) to not re-request if from Stripe. |
|
* updated parser to always push in prebilling field to subscription schedule object * updated parser to always push in prebilling field to subscription schedule object * added warning section * added changes to openapi spec * added test * added tests * stripe billing is behaving properly for backdated orders now * fixed backdated logic * addressed feedback Co-authored-by: arnoldezeolisa <[email protected]>
Fixes #896
r? @ob-stripe
cc @stripe/api-libraries