Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Capability resource and APIs #855

Merged
merged 1 commit into from
May 14, 2019

Conversation

remi-stripe
Copy link
Contributor

cc @stripe/api-libraries

@ob-stripe ob-stripe self-assigned this May 14, 2019
@ob-stripe ob-stripe changed the title [WIP] Add support for the Capability resource and APIs Add support for the Capability resource and APIs May 14, 2019
@ob-stripe
Copy link
Contributor

r? @brandur-stripe

const (
CapabilityDisabledReasonPendingOnboarding CapabilityDisabledReason = "pending.onboarding"
CapabilityDisabledReasonPendingReview CapabilityDisabledReason = "pending.review"
CapabilityDisabledReasonRejectedFraud CapabilityDisabledReason = "rejected_fraud"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, it looks like this isn't a mistake (as it's in the API), but we use an underscore in rejected_fraud and a dot everywhere else (i.e. rejected.listed)?

Think it's okay to merge it given it's ubiquitous, but will follow up elsewhere.

@brandur-stripe
Copy link
Contributor

LGTM. I'll pull this in since Remi is out.

@brandur-stripe brandur-stripe merged commit 2857c2b into master May 14, 2019
@brandur-stripe brandur-stripe deleted the remi-add-account-capabilities branch May 14, 2019 20:46
@ob-stripe
Copy link
Contributor

Thanks Brandur!

@brandur-stripe
Copy link
Contributor

Released as 60.15.0.

nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.8 to 1.13.9.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.13.8...v1.13.9)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants