Add support for TaxID resource and APIs #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-tax-ids
branch
from
d8a3f31 to
9344782
Compare
remi-stripe
changed the title
|
This is now ready for review. @mickjermsurawong-stripe can you do a first pass to see what is missing? I'll then re-assign to @brandur-stripe to make sure it matches our conventions for the library |
remi-stripe
force-pushed
the
remi-add-tax-ids
branch
from
9344782 to
f2cb852
Compare
|
@mickjermsurawong-stripe Friendly bump as this is being released now in the API |
|
Also assigning to @brandur-stripe as the feature is now live and the team would like to release this |
customer.go
Outdated
| Shipping *CustomerShippingDetails `json:"shipping"` | ||
| Sources *SourceList `json:"sources"` | ||
| Subscriptions *SubscriptionList `json:"subscriptions"` | ||
| TaxIds *TaxIDList `json:"tax_ids"` |
There was a problem hiding this comment.
Let's do TaxIDs here instead.
There was a problem hiding this comment.
ah nice catch, surprised the linter did not say anything, it complained about a lot of other fields! Fixed, PTAL
stripe-ci
assigned remi-stripe and unassigned brandur-stripe and mickjermsurawong-stripe
remi-stripe
force-pushed
the
remi-add-tax-ids
branch
from
f2cb852 to
07ce458
Compare
brandur-stripe
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @stripe/api-libraries