Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic fields in Charge's PMD 3DS field #832

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

remi-stripe
Copy link
Contributor

This PR adds the fields we just approved for the payment_method_details[card][three_d_secure] hash on Charge. In the future we will add more information but we want to get those out quickly for users to be able to identify 3DS-based Charges on PaymentMethod.

r? @brandur-stripe
cc @stripe/api-libraries @asolove-stripe

Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Remi. LGTM.

@remi-stripe remi-stripe merged commit f73985e into master Apr 16, 2019
@remi-stripe remi-stripe deleted the remi-add-charge-pmg-3ds branch April 16, 2019 17:22
nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
* Updated QA package install

* Reorg tests

* assertions for enabled field

* Support passing enabled, merge field_defaults

* Test for enabled and merging defaults

* Check for configuration_hash in controller

* Test for configuration_hash

* Update test/controllers/test_configurations_controller.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants