-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a long list of missing params and properties #820
Conversation
Params `form:"*"` | ||
PersonalIDNumber *string `form:"personal_id_number"` | ||
Params `form:"*"` | ||
IDNumber *string `form:"id_number"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change and likely requires a major version to play it safe even if it likely did not work.
35810dd
to
2e49535
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes look good to me Remi!
And wow — it's so cool that we caught all these before a user noticed and complained about any of them! WE (finally) HAVE THE TECHNOLOGY.
refund.go
Outdated
@@ -38,6 +38,7 @@ type RefundParams struct { | |||
// For more details see https://stripe.com/docs/api#list_refunds. | |||
type RefundListParams struct { | |||
ListParams `form:"*"` | |||
Charge *string `form:"charge"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more created range here please @remi-stripe
https://stripe.com/docs/api/refunds/list#list_refunds-created
2e49535
to
83216d4
Compare
@brandur-stripe, would like your thoughts on representing empty string as a way to unset params please? These are a pattern of params we currently don't support in Go but it's in OpenAPI.
On a separate note, I would like to keep this PR opened for at least this week, in case I missed flagging params among things we decided to actually not support and the empty string param. |
@mickjermsurawong-stripe IMO we should not keep such a PR open for a week. There's no real upside to "waiting until we find more", we would just do a brand new PR at that point. I also think the empty params should be resolved entirely separately and not in this PR. We should also talk about the best approach internally instead. |
ah that's fair. I'm good with merging this then |
+1. I think we're going to need to add a new property (e.g. |
The build was stuck but seems working now. I can take the release |
@brandur-stripe yeah I canceled and restarted. Leaving the release to you, thanks a lot! Reminder that it's a major version to be safe |
Released as 60.0.0. |
ah thank you @brandur-stripe! i'm just about reading instructions and preparing the release message! |
Oops, sorry @mickjermsurawong-stripe — I didn't mean to step on your toes. Somehow I read the "you" in as meaning me, hah (which reading through again makes no sense I see). |
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES) - [Commits](SeleniumHQ/selenium@selenium-4.4.0...selenium-4.5.0) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
r? @brandur-stripe
cc @mickjermsurawong-stripe who found all of those for us.
cc @stripe/api-libraries