Prevents Object from being serialized on the Event resource
#798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ type EventRequest struct { | |||
|
|
|||
| // EventData is the unmarshalled object as a map. | |||
| type EventData struct { | |||
| Object map[string]interface{} | |||
| Object map[string]interface{} `json:"-"` | |||
There was a problem hiding this comment.
Do you think that we could add a comment here that explains that despite the json:"-", this property will be populated independently? Maybe something like:
Object is a raw mapping of the API resource contained in the event.
Although marked with
json:"-", it's still populated independently by a customUnmarshalJSONimplementation.
remi-stripe
force-pushed
the
remi-fix-event-serialization
branch
from
c9a0e11 to
10eefd7
Compare
remi-stripe
force-pushed
the
remi-fix-event-serialization
branch
from
10eefd7 to
15bb861
Compare
|
@brandur thanks for the recommendation. Added your proposal. PTAL |
brandur-stripe
approved these changes
Mar 4, 2019
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
Bumps [mocha](https://github.com/freerange/mocha) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/freerange/mocha/releases) - [Changelog](https://github.com/freerange/mocha/blob/main/RELEASE.md) - [Commits](freerange/mocha@v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #797
r? @brandur-stripe
cc @stripe/api-libraries