Add support for billing thresholds #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-billing-thresholds
branch
from
01da3f0 to
77d0cfc
Compare
clintonb-stripe
approved these changes
Jan 17, 2019
|
(like the other one, removing the approval to leave that to Brandur. Thanks for the review Clinton!) |
remi-stripe
force-pushed
the
remi-add-billing-thresholds
branch
from
77d0cfc to
74b524c
Compare
There was a problem hiding this comment.
A couple minor comments, but otherwise LGTM!
ptal @remi-stripe
invoice.go
Outdated
| @@ -217,6 +219,19 @@ type InvoiceCustomField struct { | |||
| Value string `json:"value"` | |||
| } | |||
|
|
|||
| // InvoiceThresholdReason is a structure representing a reason for a billing threshold. | |||
| type InvoiceThresholdReason struct { | |||
| AmountGte int64 `json:"amount_gte"` | |||
There was a problem hiding this comment.
I'm assuming gte = "greater than or equal". Can we upcase it in all instances to be GTE? Things like ID, PDF, or URL are pretty ubiquitous convention through the library.
invoice.go
Outdated
| // InvoiceThresholdReasonItemReason is a structure representing the line items that | ||
| // triggered an invoice. | ||
| type InvoiceThresholdReasonItemReason struct { | ||
| LineItemIds []string `json:"line_item_ids"` |
There was a problem hiding this comment.
And similarly here: IDs.
remi-stripe
force-pushed
the
remi-add-billing-thresholds
branch
from
74b524c to
4a7fdb9
Compare
remi-stripe
force-pushed
the
remi-add-billing-thresholds
branch
from
4a7fdb9 to
4d687a0
Compare
|
@brandur-stripe Fixed, PTAL (and thank you) |
|
LGTM! |
|
Released as 55.11.0. |
nadaismail-stripe
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
This one is a bit complex as it's across multiple resources and no specific test was added for it so we need to make sure it matches OpenAPI.
cc @clintonb-stripe Could you double check that I added the right set of properties too and I'm not missing any? (Java only lists properties, not parameters).
Docs: https://stripe.com/docs/billing/subscriptions/metered-billing/thresholds
Internal PR with gate removal: #126799