Add new properties to TransferReversal
#765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support `destination_payment_refund` and `source_refund`.
remi-stripe
force-pushed
the
remi-add-connect-properties
branch
from
02556d6 to
c0f3625
Compare
|
Sorry Mick, wrong PR, assigning to @brandur-stripe instead |
|
ah.. since I was already looking.. I can verify that the two fields are expandable resources for Refund! |
|
Yeah, this was just added in the API and I released stripe-mock 0.43.0 for this, but stripe-go never explicitly tests this (because the deserialization of a resource is already well tested elsewhere) |
|
LGTM @remi-stripe! I'll leave it to you to release unless you'd like me to. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* updated sync record to use relative links to records * Using ID reference for the URL Co-authored-by: Mike Bianco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
destination_payment_refundandsource_refundonTransferReversal.cc @stripe/api-libraries
NOT asking for review yet as those properties are not expandable and I want to make sure it's expected to avoid a future breaking change.