Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for application_fee_amount on Charge #763

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

remi-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

@brandur-stripe
Copy link
Contributor

LGTM.

Just flagging that it seems that the way this was implemented, application_fee_amount parameters on create and capture won't show up in the docs (and probably not the OpenAPI spec either), which isn't super great because I think stripe-mock would reject the request if you included that parameter.

@brandur-stripe brandur-stripe merged commit 21bee2b into master Jan 9, 2019
@brandur-stripe brandur-stripe deleted the remi-add-applicationfeeamount branch January 9, 2019 21:19
@brandur-stripe
Copy link
Contributor

Released as 55.8.0.

nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
* Friendly user error when order does not have quote

* Minor readme update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants