Add support for actionable and has_liability_shift on IssuerFraudRecord #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Charge *Charge `json:"charge"` | ||
| Created int64 `json:"created"` | ||
| IssuerFraudType IssuerFraudType `json:"fraud_type"` | ||
| HasLiabilityShift bool `json:"has_liability_shift"` |
There was a problem hiding this comment.
Sorry about the nit, but off-by-one error on alphabetization: should be above IssuerFraudType.
There was a problem hiding this comment.
damn nice catch. Order was correct but property should be named FraudType. Fixed!
There was a problem hiding this comment.
damn nice catch. Order was correct but property should be named
FraudType. Fixed!
Oops! Yep, totally right.
|
Minor note, but otherwise LGTM. Thanks as usual @remi-stripe! |
remi-stripe
force-pushed
the
remi-ifr-add-actionable
branch
from
49b1892 to
51ae562
Compare
|
@brandur-stripe Fixed. PTAL |
|
LGTM. |
|
Released as 55.3.0. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
…ed (#742) * Tests for orders without a billing cycle * sfdx version bump * Fixing subscription reference typing * Creatge advance_test_clock helper * Factory improvements * Eliminate dependence on the upcoming invoice api call * Notes about prorated backend order amendments * Typing fixes * Typing fix * Adding timezone to ci * test fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries