Add support for the Checkout Session resource #740
Conversation
remi-stripe
force-pushed
the
remi-add-checkout-sessions
branch
from
4c49cb0 to
e59dba0
Compare
remi-stripe
force-pushed
the
remi-add-checkout-sessions
branch
from
e59dba0 to
7bb4688
Compare
remi-stripe
changed the title
|
Related to stripe/stripe-dotnet#1440 |
There was a problem hiding this comment.
Awesome Remi. Left a couple minor comments, but looking great.
ptal @remi-stripe
| }) | ||
| assert.Nil(t, err) | ||
| assert.NotNil(t, session) | ||
| } |
There was a problem hiding this comment.
Should we try to exercise Get as well?
| // creation on a checkout session. | ||
| type CheckoutSessionSubscriptionDataParams struct { | ||
| Items *CheckoutSessionSubscriptionDataItemsParams `form:"items"` | ||
| TrialEnd *int64 `form:"trial_end"` |
There was a problem hiding this comment.
This might also need its own Params so that it can get a Metadata.
There was a problem hiding this comment.
Ah yes I forgot to ask you: does it just work? Do we explicitly go through nested Params the right way?
There was a problem hiding this comment.
You'd have to write a test to be 100% sure, but yeah, Params doesn't do anything special really, so it should work fine even if nested down on a substructure like this.
The one downside of course is that Params has a bunch of things on it that are not relevant to this struct (e.g. idempotency key, headers, Stripe-Account ...), so another alternative would be just to add Metadata map[string]string form:"metadata"`` directly. The downside of that of course is that you'd also have to manually add the AddMetadata helper to the struct if you wanted to support that.
There was a problem hiding this comment.
Woot that magically just works. Nice catch! I think it's likely easier and more explicit that way than having to do something custom that users would not expect.
| // CheckoutSessionPaymentIntentDataTransferDataParams is the set of parameters allowed for the | ||
| // transfer_data hash. | ||
| type CheckoutSessionPaymentIntentDataTransferDataParams struct { | ||
| Destination *string `form:"destination"` |
There was a problem hiding this comment.
Should this also have Amount?
There was a problem hiding this comment.
No amount is gated in theory (and there for PI because it was ungated before launch)
There was a problem hiding this comment.
Ah, got it. Okay, thanks!
remi-stripe
force-pushed
the
remi-add-checkout-sessions
branch
from
7bb4688 to
ea3749a
Compare
|
@brandur-stripe Thanks for catching those issues. I just fixed each one. PTAL |
* More logging info when creating a new phase * More refactoring and logging additions in prep for pulling existing price from order line * Pulling price reuse tests into a dedicated file * Nilclass fix
This resource is now ready to be released. The PR has been updated to match the latest spec.
r? @brandur-stripe
cc @stripe/api-libraries