Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IssuingCard param value to ephemeral_key.go #728

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

jack-stripe
Copy link
Contributor

We now accept an issuing_card parameter in the API when making an ephemeral key; this allows doing so from the Go bindings.

r? @remi-stripe

@remi-stripe
Copy link
Contributor

Going to re-assign to @brandur-stripe because of the build errors. Likely something else that changed recently in one of our third-party libraries.

@brandur-stripe
Copy link
Contributor

Thanks @jack-stripe!

I think your build errors are just because you're using an outdated .travis.yml file — we've since addressed these issues in various other PRs. Would you mind rebasing and re-pushing?

@jack-stripe jack-stripe force-pushed the jack-issuing-ephemeral-keys branch from 8c745a3 to 107d07d Compare November 26, 2018 19:11
@jack-stripe
Copy link
Contributor Author

Oh, my bad! Just re-pushed.

@brandur-stripe
Copy link
Contributor

LGTM!

@brandur-stripe brandur-stripe merged commit cffd292 into master Nov 26, 2018
@brandur-stripe brandur-stripe deleted the jack-issuing-ephemeral-keys branch November 26, 2018 19:18
@brandur-stripe
Copy link
Contributor

Released as 53.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants