Drop Go 1.8 from the build matrix #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, it appears that new changes in the `golang.org/x/net/http2` package have caused it to no longer build under Go 1.8. As noted in Go's release policy [1], the latest two Go versions are officially supported, making that Go 1.11 and Go 1.10 currently. We do see ~10% users on Go 1.8 still which is larger than we'd hope when dropping an old version, but we don't have too much choice here. We believe that an upgrade to Go 1.9 for those users should be straightforward given that there generally no backward incompatible changes between new Go versions. See also discussion in #715. [1] https://golang.org/doc/devel/release.html#policy
|
LGTM |
|
Thanks Remi! |
This was referenced Nov 6, 2018
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Dropping sorbet version * Bump bundler version * Cleaner end time logic in poller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, it appears that new changes in the
golang.org/x/net/http2package have caused it to no longer build underGo 1.8.
As noted in Go's release policy [1], the latest two Go versions are
officially supported, making that Go 1.11 and Go 1.10 currently.
We do see ~10% users on Go 1.8 still which is larger than we'd hope when
dropping an old version, but we don't have too much choice here. We
believe that an upgrade to Go 1.9 for those users should be
straightforward given that there generally no backward incompatible
changes between new Go versions.
See also discussion in #715.
[1] https://golang.org/doc/devel/release.html#policy
r? @remi-stripe