Set Request.GetBody
#711
Set Request.GetBody
#711
Conversation
Here we set `Request.GetBody`, which is used under certain circumstances by the internal `net/http` core like in the case of a redirect. This will usually not end up being used, but it doesn't hurt to set it in case it is (it's run lazily, and few additional resources are needed in case it's not run). Fixes #710.
|
@brandur-stripe looks like this does not work on Go 1.7 |
|
@remi-stripe Doh! Yeah, I just saw that. Any FUD for dropping support for <= 1.7? It's not officially supported by the Go core team, and hasn't been since the release of Go 1.9 in August 2017 (1+ year) according to their version support policy. Also, looking at OB's language metrics page, <= 1.7 is roughly ~= 1.5% of our users, which is quite small. Those users will also likely be able to upgrade easily because there are ~no breaking changes on the path to a more modern Go version. |
|
@brandur-stripe Based on your stats that sounds fine to me (though it becomes a major release then) |
|
Thanks Remi. Alright, I just added 1.11 to the matrix and dropped 1.7. I'll release as a major. |
|
Released as 52.0.0. |
Here we set
Request.GetBody, which is used under certain circumstancesby the internal
net/httpcore like in the case of a redirect. Thiswill usually not end up being used, but it doesn't hurt to set it in
case it is (it's run lazily, and few additional resources are needed in
case it's not run).
Fixes #710.
r? @remi-stripe
cc @stripe/api-libraries