Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Terminal bindings to clients #708

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Conversation

mattlisiv
Copy link

Hi,

I am currently working with the Stripe Terminal beta and utilizing a Go backend. At the moment, the terminal bindings are not within the base client API.

Is this purposeful? If not, I took a stab at adding them into the client.

Thanks!
Matt

@brandur-stripe
Copy link
Contributor

Thanks @mattlisiv! These seem to get often overlooked because they're easy to forget.

Would you mind pluralizing the new additions? (e.g., TerminalConnectionTokens instead of TerminalConnectionToken) This will be in keeping with the convention elsewhere.

@mattlisiv
Copy link
Author

@brandur-stripe , updated!

@brandur-stripe
Copy link
Contributor

Thanks again @mattlisiv.

@brandur-stripe brandur-stripe merged commit c9836c7 into stripe:master Oct 19, 2018
@brandur-stripe
Copy link
Contributor

Released as 51.4.0.

nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
Bumps [resque-scheduler](https://github.com/resque/resque-scheduler) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/resque/resque-scheduler/releases)
- [Changelog](https://github.com/resque/resque-scheduler/blob/master/CHANGELOG.md)
- [Commits](resque/resque-scheduler@v4.5.0...v4.6.0)

---
updated-dependencies:
- dependency-name: resque-scheduler
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants