Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the Webhook Endpoint resource #706

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Add support for the Webhook Endpoint resource #706

merged 1 commit into from
Oct 31, 2018

Conversation

remi-stripe
Copy link
Contributor

cc @stripe/api-libraries

@remi-stripe remi-stripe force-pushed the remi-add-webhook-endpoint branch from 794e282 to b71a4a0 Compare October 31, 2018 19:33
@remi-stripe remi-stripe changed the title [WIP] Add support for the Webhook Endpoint resource Add support for the Webhook Endpoint resource Oct 31, 2018
@remi-stripe remi-stripe force-pushed the remi-add-webhook-endpoint branch from b71a4a0 to eea5287 Compare October 31, 2018 19:34
@remi-stripe
Copy link
Contributor Author

r? @ob-stripe

ob-stripe
ob-stripe suggested changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a separate struct for update parameters, with disabled and without connect.

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Oct 31, 2018
@remi-stripe remi-stripe force-pushed the remi-add-webhook-endpoint branch from eea5287 to feb698b Compare October 31, 2018 19:40
@remi-stripe
Copy link
Contributor Author

I think you need a separate struct for update parameters, with disabled and without connect.

That's not something we do in Go today. We don't have a separate struct for create and update as the vast majority of params are shared.

I added disabled though since you're correct that it was missing.

@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Oct 31, 2018
@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Oct 31, 2018
@remi-stripe remi-stripe force-pushed the remi-add-webhook-endpoint branch from feb698b to ac90c4b Compare October 31, 2018 19:47
@remi-stripe remi-stripe force-pushed the remi-add-webhook-endpoint branch from ac90c4b to 095bd3a Compare October 31, 2018 20:00
@remi-stripe remi-stripe merged commit 37fd6c6 into master Oct 31, 2018
@remi-stripe remi-stripe deleted the remi-add-webhook-endpoint branch October 31, 2018 20:31
nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
@mbianco-stripe
Allow nil decimal normalization (#706)
c327a6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees

@remi-stripe remi-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remi-stripe @ob-stripe @stripe-ci