Add support for the Person resource #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-person
branch
from
397b191 to
4bf4916
Compare
remi-stripe
force-pushed
the
remi-add-person
branch
5 times, most recently
from
c1b4e06 to
4774113
Compare
|
r? @ob-stripe |
ob-stripe
approved these changes
Oct 31, 2018
bankaccount/client_test.go
Outdated
| @@ -9,31 +9,31 @@ import ( | |||
| ) | |||
|
|
|||
| func TestBankAccountDel_ByAccount(t *testing.T) { | |||
| bankAcount, err := Del("ba_123", &stripe.BankAccountParams{ | |||
| bankaccount, err := Del("ba_123", &stripe.BankAccountParams{ | |||
There was a problem hiding this comment.
Maybe bankAccount instead?
There was a problem hiding this comment.
it's bankaccount in the whole file, that's how go usually does this.
There was a problem hiding this comment.
ah yeah no, I'm the one who changed this apparently. Hmmm will look
remi-stripe
force-pushed
the
remi-add-person
branch
from
4774113 to
76a79b5
Compare
remi-stripe
force-pushed
the
remi-add-person
branch
from
76a79b5 to
13085fb
Compare
|
re-approving since I just changed the name of the variable to |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Use rubygems hashdiff * type fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @stripe/api-libraries