Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating IssuingCardDetails.Number json tag to 'number' #697

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

JessicaCGlenn
Copy link

Currently the IssuingCardDetails struct returns with a zero value for Number, this is because the json tag in the type declaration is set to 'type' and the API request is returning 'number'.

This pull request simply changes the json tag in the IssuingCardDetails declaration to 'number' to fix this issue.

@remi-stripe
Copy link
Contributor

@JessicaCGlenn Thanks a lot for fixing my mistake, sorry about the trouble! Going to release this now :)

@remi-stripe remi-stripe merged commit 68f8134 into stripe:master Sep 24, 2018
@remi-stripe
Copy link
Contributor

@JessicaCGlenn I just released it as 49.2.0, thanks again for the work!

@JessicaCGlenn
Copy link
Author

You're very welcome, thank you for the speedy response!! Have an awesome week :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants