Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support expansion of products in plans #693

Merged

Conversation

majelbstoat
Copy link
Contributor

per @remi-stripe, should fix #692.

@remi-stripe
Copy link
Contributor

@majelbstoat Thanks for opening the PR so quickly :)

r? @brandur-stripe to make sure it's correct and release. I think this is a breaking change so tagging as such.
cc @stripe/api-libraries

@brandur-stripe
Copy link
Contributor

LGTM!

I think this is a breaking change so tagging as such.

Yep, agreed.

@brandur-stripe brandur-stripe merged commit 4007cec into stripe:master Sep 11, 2018
@majelbstoat majelbstoat deleted the jamie/plan-product-expansion branch September 11, 2018 20:48
@brandur-stripe
Copy link
Contributor

Thanks @majelbstoat!

Released as 49.0.0.

@majelbstoat
Copy link
Contributor Author

Thanks folks! (This work sponsored by ClassPass ❤️)

nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
Bumps [minitest](https://github.com/seattlerb/minitest) from 5.16.2 to 5.16.3.
- [Release notes](https://github.com/seattlerb/minitest/releases)
- [Changelog](https://github.com/minitest/minitest/blob/master/History.rdoc)
- [Commits](minitest/minitest@v5.16.2...v5.16.3)

---
updated-dependencies:
- dependency-name: minitest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expanding a product when retrieving a plan causes JSON unmarshalling errors
3 participants