Add go.mod to support the new module system
#689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `go.mod` file to support the new experimental Go module system which is likely to see full release pretty soon. See #559 for original context. I originally tried this in #563, but ran into trouble because Vgo wasn't smart enough to have subpackages in a module know to use their parent's version, so we'd see problems where it'd use stripe-go v46 (for example), go on to look at stripe-go/charge, see that it depended on stripe-go, so it would re-ascend the tree and default to stripe-go v1 instead of v46! See #563 for details, but it didn't work at all and I ended up just reverting. Since then it seems like some major improvements have been made and subpackages can now resolve their parents version correctly. (I tried this in a test project and although I'm not 100% sure that it was doing t he right thing because `go.mod` is not yet in GitHub's master, it looked like it was working). Also, the system has improved to the point where the `/v46` path suffix is no longer needed in `vgo.mod` which means that we don't even have to updated our build scripts. That's great. After this lands, I'll make sure to mess around it with a little more to make sure everything looks like it's doing what expect.
Closed
|
I'm 100% trusting you to check that this works as expected, but lgtm :) |
Haha. I'll let you know. Thanks! |
|
Released as 46.1.0. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Updated plan * idempotent notes * Break out prorated order amendment test * Plan update * Moving stripe price precision to a constant * Core proration use case tests * Initial working version of amendment helper logic * Memoized price helper * Only set sub term on products when we know it matches the billing frequency * Initial take at add_invoice_items generation * Improved price multiplier calculation * todo docs update * Allow error context to be called w/o state * Some more debugging functions from working with cloudflare * Calculate billing periods I have a feeling we don't need this because of the cotermed thing * Docs improvement * Test expansion for standard amendment tests * Refactoring CommonHelpers to namespace behind Critic * Test factory updates, including lots of Stripe factories * Using new stripe id generator * Fixing bad boolean in order amendment logic * Another round of expansions on the prorated order amendment logic * Create customer with card helper * Fixing price test comparison * Fix error context typing error * Typing fixes * Fixing error context references * Better logging on sync record creation * Adjust order failures for improved order logic * Fix sub term through quote error test * Gracefully handle terminations We can't prorate these! * Logs so we know something isn't stalled out * Centralize price equality logic, normalize decimal values * extract out backend proration test and temp skipping it * Another round of price equality fixes * Fix for multiple quantity test * Accept price param in metered billing * Add idempotency keys to cancellation & update calls * Use translate_product to get SF context * Users could map invalid field values, use raw error * Fix sync record tests * Typing fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
go.modfile to support the new experimental Go module systemwhich is likely to see full release pretty soon.
See #559 for original context. I originally tried this in #563, but ran
into trouble because Vgo wasn't smart enough to have subpackages in a
module know to use their parent's version, so we'd see problems where
it'd use stripe-go v46 (for example), go on to look at stripe-go/charge,
see that it depended on stripe-go, so it would re-ascend the tree and
default to stripe-go v1 instead of v46! See #563 for details, but it
didn't work at all and I ended up just reverting.
Since then it seems like some major improvements have been made and
subpackages can now resolve their parents version correctly. (I tried
this in a test project and although I'm not 100% sure that it was doing
t he right thing because
go.modis not yet in GitHub's master, itlooked like it was working).
Also, the system has improved to the point where the
/v46path suffixis no longer needed in
vgo.modwhich means that we don't even have toupdated our build scripts. That's great.
After this lands, I'll make sure to mess around it with a little more to
make sure everything looks like it's doing what expect.
r? @ob-stripe
cc @stripe/api-libraries