Fix two issues with List tests #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure that `subscription_item` is not sent as a parameter when listing usage record summaries * Update the test for usage record summary * Fix the bank account list test for Accounts to pass the right parameter
|
LGTM.
Just for release purposes: was this "just" wrong, or was it causing a problem? |
|
Fairly sure it was wrong and the API would have returned an error so it's likely no one used it yet. The issue is that stripe-mock did not validate extra parameters on GET requests so I did not catch it. |
|
Ah, I see! Okay, thanks. |
|
Released as 43.1.1. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Adding metadata keys enum * Supporting block customization when duplicating price * Allow enum to be passed directly when generating metadata keys * Missing price fields * Fix block naming to be consistent * Todo docs update * Fixing price typing issue * Fix missing metadata check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subscription_itemis not sent as a parameter when listing usage record summariesr? @brandur-stripe
cc @stripe/api-libraries