Move to API version 2018-08-23 #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,6 +103,18 @@ type CustomerShippingDetails struct { | |||
| Phone string `json:"phone"` | |||
| } | |||
|
|
|||
| // CustomerTaxInfo is the structure containing tax information for the customer. | |||
| type CustomerTaxInfo struct { | |||
There was a problem hiding this comment.
I think both these structs are missing a field definition in Customer.
There was a problem hiding this comment.
Damn nice catch. I also discovered I was not on the latest master so I fixed that too. Let's see if tests pass
|
Thanks for the diligence as usual Remi! Left a minor comment, but otherwise LGTM. |
* Remove `at_period_end` on subscription cancelation * Remove `business_vat_id` on Customer * Rename `amount` to `unit_amount` on Plan's Tiers
remi-stripe
force-pushed
the
remi-api-version-2018-08-23
branch
from
ff45090 to
eb91bf7
Compare
remi-stripe
force-pushed
the
remi-api-version-2018-08-23
branch
from
eb91bf7 to
3cf614b
Compare
|
@brandur-stripe okay I think I got things right this time. PTAL |
|
LGTM. |
|
Released as 43.0.0. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has multiple major changes due to the move to the latest API version and some new properties/breaking changes.
tax_infoandtax_info_verificationon the customerbusiness_vat_idon the Customeramounttounit_amounton Plan's tiersat_period_end.r? @brandur-stripe
cc @stripe/api-libraries
(Flagging that we need a new stripe-mock for tests to pass because of the change to
amounton Tiers)